#656 Eliminate type casting warnings
Closed: Fixed Opened by sgallagh.

GCC 4.5 introduced a new warning regarding qualifiers for casting.

../src/sss_client/pam_sss.c: In function 'do_pam_conversation':
../src/sss_client/pam_sss.c:346:41: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/tests/sysdb-tests.c: In function ‘test_sysdb_update_members’:
../src/tests/sysdb-tests.c:2223:32: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/tests/sysdb-tests.c:2237:32: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/tests/sysdb-tests.c:2238:32: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/tests/sysdb-tests.c:2252:32: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/ldap/sdap_async_accounts.c: In function 'sdap_initgr_rfc2307_process':
../src/providers/ldap/sdap_async_accounts.c:2012:32: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/ldap/sdap_async_accounts.c:2013:32: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/ldap/sdap_async_accounts.c: In function 'save_rfc2307bis_user_memberships':
../src/providers/ldap/sdap_async_accounts.c:3321:32: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/ldap/sdap_async_accounts.c:3322:32: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/ldap/sdap_async_accounts.c: In function 'rfc2307bis_nested_groups_update_sysdb':
../src/providers/ldap/sdap_async_accounts.c:3785:32: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/ldap/sdap_async_accounts.c:3786:32: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/ldap/sdap.c: In function 'build_attrs_from_map':
../src/providers/ldap/sdap.c:430:5: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/proxy/proxy_id.c: In function 'get_gr_name':
../src/providers/proxy/proxy_id.c:506:51: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/proxy/proxy_id.c: In function 'get_gr_gid':
../src/providers/proxy/proxy_id.c:657:51: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/proxy/proxy_id.c: In function 'enum_groups':
../src/providers/proxy/proxy_id.c:812:51: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/ldap/sdap_async_accounts.c: In function 'sdap_initgr_rfc2307_process':
../src/providers/ldap/sdap_async_accounts.c:2012:32: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/ldap/sdap_async_accounts.c:2013:32: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/ldap/sdap_async_accounts.c: In function 'save_rfc2307bis_user_memberships':
../src/providers/ldap/sdap_async_accounts.c:3321:32: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/ldap/sdap_async_accounts.c:3322:32: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/ldap/sdap_async_accounts.c: In function 'rfc2307bis_nested_groups_update_sysdb':
../src/providers/ldap/sdap_async_accounts.c:3785:32: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/ldap/sdap_async_accounts.c:3786:32: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/providers/ldap/sdap.c: In function 'build_attrs_from_map':
../src/providers/ldap/sdap.c:430:5: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/confdb/confdb_setup.c: In function ‘confdb_init_db’:
../src/confdb/confdb_setup.c:398:5: warning: new qualifiers in middle of multi-level non-const cast are unsafe
../src/tests/files-tests.c: In function ‘main’:
../src/tests/files-tests.c:313:5: warning: new qualifiers in middle of multi-level non-const cast are unsafe

We need to ensure that these casts are safe


Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.5.0
owner: somebody => sgallagh

Fields changed

status: new => assigned

Fixed by
- 1ebddb7c2498f715f108b8721fa5fc8d4892e14d
- 3fa7380908997eda5e45c5f4d6b512a954d3bc3c
- 4230a43c97e13c83ce4e230d45c4f0f11b37fe4e
- f8a60e728780a8230ed4fa9c5350fa94534f0543
- 5e4ea20cf1e31ce4fee5cbfa92ea120901a5bd1e
- e194940b169691939c5c8f2a29754df1c7678a42

fixedin: => 1.5.0
resolution: => fixed
status: assigned => closed

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to sgallagh
- Issue set to the milestone: SSSD 1.5.0

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1698

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata