#631 Issues with write_krb5info_file()'s use of "ret"
Closed: Fixed Opened by sgallagh.

There are two issues here.

  1. Uninitialized return of {{{ret}}}

    if (written != server_len) {
        DEBUG(1, ("Write error, wrote [%d] bytes, expected [%d]\n",
                   written, server_len));
        goto done;
    }
    
  2. Inconsistent use of {{{ret}}}. Some places we return an errno_t value (which is correct, by the function's return type), and other times we return errors directly from functions like {{{write()}}} and {{{fchmod()}}} which do not use errno_t return values.


Fields changed

owner: jhrozek => sbose

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.4.0

Fixed by 5d395f5cecf4be9d9ebebb51515ad4e590dcc630

fixedin: => 1.4.0
resolution: => fixed
status: new => closed

Sorry, correction.
Fixed by f7fa22da5d865221f84371d6b522444e1591164c

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to sbose
- Issue set to the milestone: SSSD 1.4.0

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1673

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata