From Coverity:
Comparing "realm_str" to null implies that "realm_str" might be null. 175 if (realm_str) { 176 SAFEALIGN_SET_UINT32(&buf->data[rp], strlen(realm_str), &rp); 177 safealign_memcpy(&buf->data[rp], realm_str, strlen(realm_str), &rp); 178 } else { 179 SAFEALIGN_SET_UINT32(&buf->data[rp], 0, &rp); 180 }
We need to fix this. We're definitely dereferencing NULL if the realm_str doesn't exist.
Fields changed
owner: somebody => jhrozek
status: new => assigned
milestone: NEEDS_TRIAGE => SSSD 1.2.1
Fixed by be3cb9b976bd994b2cd6e0217e41892f46d174dd
fixedin: => 1.2.1 keywords: => coverity resolution: => fixed status: assigned => closed
rhbz: => 0
Metadata Update from @sgallagh: - Issue assigned to jhrozek - Issue set to the milestone: SSSD 1.2.1
SSSD is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in SSSD's github repository.
This issue has been cloned to Github and is available here: - https://github.com/SSSD/sssd/issues/1550
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.