From Coverity:
Dereferencing null variable "error_list". 369 error = col_add_binary_property(*error_list, NULL, 370 ERROR_TXT, &pe, sizeof(pe)); ... Dereferencing null variable "error_list". 394 error = col_add_binary_property(*error_list, NULL, 395 WARNING_TXT, &pe, sizeof(pe));
We need to handle the case where no error_list was requested.
Comparing "server->common" to null implies that "server->common" might be null. 1125 if (!server->common && fo_is_srv_lookup(server)) { 1126 return "SRV lookup meta-server"; 1127 } 1128 Dereferencing null variable "server->common". 1129 return server->common->name; 1130}
This will crash here if server->common == NULL and fo_is_server_lookup(server) returns false.
component: INI Parser => Failover owner: dpal => somebody
Please ignore the previous comment. I meant to create a new bug.
component: Failover => INI Parser owner: somebody => dpal
Fields changed
milestone: NEEDS_TRIAGE => SSSD 1.2.1
keywords: => coverity
Fixed by 0b67f531ca2c0a632e3b2c12095fb005ff528fa8
fixedin: => 1.2.1 resolution: => fixed status: new => closed
rhbz: => 0
Metadata Update from @sgallagh: - Issue assigned to dpal - Issue set to the milestone: SSSD 1.2.1
SSSD is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in SSSD's github repository.
This issue has been cloned to Github and is available here: - https://github.com/SSSD/sssd/issues/1546
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.