#4049 Sudo prompt for smart card authentication is missing the trailing colon
Closed: Fixed by sbose. Opened by jjelen.

I configured sudo to authenticate using smart card. The prompt looks like this:

[jjelen@t470s ~]$ sudo true
PIN for jjelen

I think the prompt should end with the colon (mostly because the checks in sudo function use_pam_prompt() [1]) to explicitly mark prompt waiting for user input, as it looks like when sudo asks for password. The format string is defined in [2].

I can propose the trivial pull request, but first of all I wanted to discuss this whether there is not some other reason behind this, that I am missing.

[1] https://www.sudo.ws/repos/sudo/file/tip/plugins/sudoers/auth/pam.c
[2] https://pagure.io/SSSD/sssd/blob/master/f/src/sss_client/pam_sss.c#_1612


Hi @jjelen,

there is no reason, it is just an error on my side. It would be nice if you can send a pull-request, but please note that we would prefer github (https://github.com/SSSD/sssd/pulls).

bye,
Sumit

Thank you for fast answers. I opened https://github.com/SSSD/sssd/pull/856

Metadata Update from @jhrozek:
- Issue tagged with: PR, bug

Metadata Update from @jhrozek:
- Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1736483

Issue linked to Bugzilla: Bug 1736483

Master:

  • db46cd0890057be1f72173a2ca2ae040bcf46c9a

Metadata Update from @sbose:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/5017

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata