SSSD / sssd

#3791 The cached password does not store the salt prefix
Closed: Fixed Opened by jhrozek.

Closed: Fixed
Reopen Issue

Since commit 2951a9a84bd85f384213a3e071ffc167907df2d7 where we switched from stpncpy to memcpy the salt prefix "$6$" is not stored at all. This breaks offline authentication if someone upgraded from the version that stored the prefix to one that doesn't store it.

Metadata Update from @jhrozek:
- Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1602781

Metadata Update from @jhrozek:
- Issue tagged with: bug, regression

Metadata Update from @jhrozek:
- Issue assigned to mzidek
- Issue priority set to: blocker

PR: https://github.com/SSSD/sssd/pull/625

Metadata Update from @jhrozek:
- Issue tagged with: PR

Metadata Update from @jhrozek:
- Issue close_status updated to: Fixed
- Issue set to the milestone: SSSD 1.16.3
- Issue status updated to: Closed (was: Open)

I would say there is a different solution which does not introduce a compile time warning.

@jhrozek, please check changes in https://pagure.io/SSSD/sssd/pull-request/3792. It even contains a unit test
Edited by lslebodn

Metadata Update from @lslebodn:
- Issue status updated to: Open (was: Closed)
  • master:
  • cd28ef7c66ba393ee7c20e99064668cd8d588883
  • f62d2af0c270a4f6143264a6cf3ce618f4a9ba80
  • 8e1576b1ce7548530bba6efaa43b321d70707a1d

Metadata Update from @jhrozek:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

master:
f62d2af
8e1576b

last two patches should be backported also to 1.4 and 1.13 branch

Thanks, I didn't realise we broke 1.13 and 1.14 as well.

sssd-1-14:
* 46682a1eb73b3d02d38cf5df600ca583add060d4
* 89a05bdaec89a8ee651836f11872d810bf0641fa
sssd-1-13:
* c7636e4721cb52f1b36bf93a3f27a247f3f9231f

(The test doesn't apply to sssd-1-13 and I currently have no time for a backport. Feel free to submit another PR if you feel strongly the test should go to sssd-1-13)

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/4789

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.
Metadata

PR bug regression

None
None
Lowest
https://bugzilla.redhat.com/show_bug.cgi?id=1602781
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.