Issue #2978: pid file name decalration is duplicated - sssd

SSSD / sssd

#2978 pid file name decalration is duplicated

Closed: Fixed Opened Mar 28, 2016 by simo.

While looking at the monitor code I realize we define SSSD_PIDFILE_PATH
in monitor.c in a different way than we define SSSD_PIDFILE in
tools_util.h

Although the definitions differ, they end up being effectively the same
string for now.

It seem to me those definition should be merged and harmonized into one.
If not a comment should be put in the code explaining why we have 2
(potentially) different pid file names.

jhrozek commented Apr 1, 2016

Easy fix, let's do this in 1.14.

milestone: NEEDS_TRIAGE => SSSD 1.14 beta

jhrozek commented Apr 14, 2016

Fields changed

rhbz: => 0

jhrozek commented Jun 20, 2016

Code deduplication doesn't have to block the beta release.

milestone: SSSD 1.14 beta => SSSD 1.14.0

jhrozek commented Jun 27, 2016

Fields changed

owner: somebody => pcech

jhrozek commented Jun 27, 2016

Fields changed

priority: major => minor

jhrozek commented Jul 1, 2016

1.14.0 should be released no later than Wednesday next week, this ticket should not block the 1.14.0 release.

milestone: SSSD 1.14.0 => SSSD 1.14.1

pcech commented Jul 26, 2016

Fields changed

status: new => assigned

pcech commented Jul 26, 2016

Fields changed

patch: 0 => 1

jhrozek commented Aug 9, 2016

master: 08cd034c8584b6f058cf565ce66f7f9f7120622f

resolution: => fixed
status: assigned => closed

lslebodn commented Jan 9, 2017

pushed also to sssd-1-13 due to other patches

sssd-1-13:

1d897ffa2f6c675a98e27b4f8f336dcda6ea8c80

Metadata Update from @simo:
- Issue assigned to pcech
- Issue set to the milestone: SSSD 1.14.1

Feb 24, 2017

pbrezina commented May 2, 2020

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/4019

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata

Assignee

pcech

Tags

None

Blocking

None

Depending on

None

Priority

High

type

defect

component

SSSD

version

1.13.3

sensitive

testsupdated

patch

rhbz

design_review

review

mark

SSSD / sssd

#2978 pid file name decalration is duplicated Closed: Fixed Opened Mar 28, 2016 by simo.

Metadata

#2978 pid file name decalration is duplicated

Closed: Fixed Opened Mar 28, 2016 by simo.