#283 Uninitialized value bug in sydb_add_group_set_attrs()
Closed: Fixed Opened by sgallagh.

From valgrind:

==30351== Conditional jump or move depends on uninitialised value(s)
==30351==    at 0x41C58B: sysdb_add_group_set_attrs (sysdb_ops.c:2414)
==30351==    by 0x41C19A: sysdb_add_group_basic_done (sysdb_ops.c:2350)
==30351==    by 0x4154B0: sysdb_op_default_done (sysdb_ops.c:241)
==30351==    by 0x4151E7: sldb_request_callback (sysdb_ops.c:163)
==30351==    by 0x4C2E422: ldb_module_done (ldb_modules.c:703)
==30351==    by 0xAC61740: mbof_add_callback (memberof.c:337)
==30351==    by 0x4C36D7E: ltdb_callback (ldb_tdb.c:1120)
==30351==    by 0x3FBE002F24: tevent_common_loop_timer_delay (in /usr/lib64/libtevent.so.0.9.3)
==30351==    by 0x3FBE00455A: (within /usr/lib64/libtevent.so.0.9.3)
==30351==    by 0x3FBE0047E5: (within /usr/lib64/libtevent.so.0.9.3)
==30351==    by 0x42C35C: server_loop (server.c:431)
==30351==    by 0x40BDC2: main (data_provider_be.c:1141)

The problem is that state->cache_timeout is never initialized before this function attempts to use it. I was unable to find any point in the code where it was referenced except here, in fact.


Fixed in 39462f9afb7512d3d8109e17b78a303b20c557ab

fixedin: => 1.0.0rc
resolution: => fixed
status: new => closed

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to simo
- Issue set to the milestone: SSSD 1.0

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1325

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata