SSSD / sssd

#1627 [RFE] Improve efficiency of diff_string_lists (and similar fns)
Closed: wontfix by pbrezina. Opened by simo.

Closed: wontfix
Reopen Issue

Although using a hash table is a clever way to diff the lists, it seem like heavy handed both memory and cpu wise.
It occurs to me that a simpler algorithm may be used:
a) copy list1 as list1_only and list2 as list2_only
b) sort list1_only and list2_only
c) create both_list as an empty array of size = list1 + list2
d) walk both lists at the same time comparing values and copying them to both_list at the same time, on a match NULL out both list1_only and list2_only values and add only once to both_list
e) resort list1_only and list2_only pushing NULLs away and keeping count of the remaining values

If the function could take in input list1 and list2 sizes as well instead of having to count them, we could save some cycles there too.

Internal optimization.

milestone: NEEDS_TRIAGE => SSSD 1.10 beta
rhbz: => 0
summary: Improve efficiency of diff_string_lists (and similar fns) => [RFE] Improve efficiency of diff_string_lists (and similar fns)

Fields changed

selected: => Not need

Moving tickets that are not a priority for SSSD 1.10 into the next release.

milestone: SSSD 1.10 beta => SSSD 1.11 beta

Fields changed

mark: => 0

Fields changed

changelog: =>
milestone: SSSD 1.13 beta => SSSD 1.13 backlog
priority: minor => trivial
review: => 0

Mass-moving tickets not planned for any immediate release and re-setting priority.

milestone: SSSD 1.13 backlog => SSSD Deferred
priority: trivial => major

Metadata Update from @simo:
- Issue set to the milestone: SSSD Patches welcome

Thank you for taking time to submit this request for SSSD. Unfortunately this issue was not given priority and the team lacks the capacity to work on it at this time.

Given that we are unable to fulfill this request I am closing the issue as wontfix.

If the issue still persist on recent SSSD you can request re-consideration of this decision by reopening this issue. Please provide additional technical details about its importance to you.

Thank you for understanding.

Metadata Update from @pbrezina:
- Issue close_status updated to: wontfix
- Issue status updated to: Closed (was: Open)

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/2669

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.
Metadata
None
None
None
None
Normal
enhancement
SSSD
1.9.2
0
0
0
0
Not need
0
0
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.