#120 [feature] ip block
Opened by brettowe. Modified

Summary

it would be nice under the settings where you can manual add urls if one could use IP CIDR
formatting.
I find that due to having numerous IP cameras on my ip networks it would be easier if I could just add a IP block to the don't filter list. since the extension ends up breaking the video.
an example would be adding 192.168.1.0/24 instead of having to manually add 192.168.1.1, 192.168.1.2, 192.168.1.3, etc


Metadata Update from @polcak:
- Issue tagged with: enhancement, good first issue

Thank you, I agree.

I interpret this issue to be about JSS Shield.

Decide if this is only about IP addresses embedded in the URLs or if we want to check IP addresses after DNS resolution. The later can be unimplementable due to several reasons like the need to have the configuration synchronously.

The later is more likely be easier to implement in Firefox and possibly be unimplementable in Chromium-based browsers due to the lack of DNS API support. However, DNS API is asynchronous and as such can be out of question for reliable modifications.

If DNS API needs to be used, multiple IP addresses can be returned, https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/dns/resolve. Is a single match sufficient? Do all IP addresses belong to the same block? What should happen if different IP addresses fall to different blocks?

smells of a AI output...
anyhow why is any API needed?
you should just match the url of the page if its an ip or dns it still has to match whatever you have in your list all this report is asking for is the mach list to be able to use something akin to a regexp

@brettowe: This issue should be fixed during the upcoming project. Are you the original reporter of the issue?

I am surprised that you mention something like regexp. I currently do not see a reason to add regexes as that would likely complicate things.

I think we should support just CIDR notation and the addresses should only match IP addresses that are directly embedded in the URL. So for example, if one would add 38.145.32.0/24, this site with the IP address of 38.145.32.40 would not be blocked as the URL would be https://pagure.io/JShelter/webextension/ and not the IP address directly.

I suggested regexp as I expect that it already exists as a dependency and doesn't require pulling in another API.
you can of course implement it however you see fit.
I stopped using this extension some time ago due to the constant headaches mainly due to cloudflare

Metadata