FedoraReview

#123 fedora-review fails to locate source_dir within mock if uniqueext is passed to mock
Closed: Fixed Opened by salimma.

Closed: Fixed
Reopen Issue

I normally separate my mock buildroots by passing uniqueext, and this worked fine in fedora-review when 0.2.0 was being developed. Now, however, with both 0.2.2 and the latest Git head, it triggers an index error when it tries to compute the directory within mock where the source is extracted, presumably because it didn't understand the uniqueext passed to mock.

Maybe uniqueext needs to be made a fedora-review option that it then passes to mock, otherwise one'd have to parse the options passed to mock with -o, which surely must be a more complicated task?

verbose log attached of an attempt to review Geary using this invocation:

./fedora-review -v -b 849455 -o"--uniqueext=geary" -m fedora-rawhide-x86_64 &> review.log

Log of review process ending with IndexError
review.log

You should be able to walk around this by using the --resultdir option instead (in mock-options). This is already scanned and handled by f-r.

Nevertheless, I will have a look into this

Hm, I was tired writing comment:1 - --resultdir is not a substitute for --uniqueext.

Fixed in b626d69bf2f3fcb841c. Many thanks for this report! Feel free to reopen bug if need be.
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.