389-ds-base

#51183 Issue 51165 - add new access log keywords for wtime and optime
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base issue51165  into  master

Download 51183.patch

Description:

In addition to the "etime" stat in the access we can also add the time the operation spent in the work queue, and how long the actual operation took. We now have "wtime" and "optime" to track these stats in the access log.

Also updated logconf for notes=F (related to a different ticket), and stats for wtime and optime.

relates: https://pagure.io/389-ds-base/issue/51165

rebased onto f104f52797f1c83f9e176c0dc02a9fbda2d971b3

All looks pretty good to me! Ack :)

Ack for me as well.
Just a question regarding the access log format. It makes sense to group [ewo]time however up to new we always append new record to the end (page result, extend string..). This new format can impact customer scripts, should we care about a "compatible" format.

I don't think we should - even appending items could break log parsers, and others, it's not a "stable" part of our api. To make guarantees like this we'd need structured logging that output in json I think.

Ack for me as well.
Just a question regarding the access log format. It makes sense to group [ewo]time however up to new we always append new record to the end (page result, extend string..). This new format can impact customer scripts, should we care about a "compatible" format.

Actually that is why I left "etime" at the end. So the end of the access log RESULT line is the same. The new keywords are injected in the middle, but I also updated logconv to handle the change as well. Our tools handle the change fine, so I don't think we need to worry about custom scripts or adding a new config option to adjust the format.

rebased onto 3246fe7930771c4deb82d979245f1810560f5c40

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4236

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.