#51139 Issue 51136 - dsctl and dsidm do not errors correctly when using JSON
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base issue51136  into  master

Download 51139.patch

Description:

dsctl and dsidm were not returning errors in a JSON object when the JSON CLI option was requested. This breaks the UI when errors occur.

fixes: https://pagure.io/389-ds-base/issue/51136

Looks good!

Can we, maybe, fix the rest of the indent issues?
Discovered like this:

cd src/lib389/
grep -rni json.dump | grep -v indent

Looks good!
Can we, maybe, fix the rest of the indent issues?
Discovered like this:
cd src/lib389/
grep -rni json.dump | grep -v indent

I thought I covered them all in a previous patch when I was doing other UI work, but I obviously missed quite a few. I'll add these into the patch and merge it. Thanks!

rebased onto 079b874c733ae99074379caa36bc9921df5c1f49

rebased onto af87048042b3b8bd65f26f32e9c257dc8a881b4f

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4192

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata