389-ds-base

#51084 Ticket 51079 - container pid start and stop issues
Closed by spichugi. Opened by firstyear.
firstyear/389-ds-base 51079-container-issues  into  master

Download 51084.patch

Bug Description: During the container startup, we were incorrectly
checking for the pidfile as we started. We also were not properly
catching sigint, and dscontainer on keyboard int was not passing
some signals through.

Fix Description: Improve signal handling in dscontainer, add sigint
as a caught signal to ns-slapd, and remove the pid file from the container
instance as we do not require it.

https://pagure.io/389-ds-base/issue/51079
https://pagure.io/389-ds-base/issue/51080

Author: William Brown william@blackhats.net.au

Review by: ???

rebased onto 6d348b711964be5bbf3c4cf52e86a6ba64d9345f

Humm.. catching SIGINT in a daemon looks weird to me. However I can not see drawback on this.
When interrupting a container could it be translated into sigterm to DS ?

Well, sigint is very similar to sigterm anyway. But anyway, the wrapper does catch sigint and translate to sigterm too. I think handling sigint is a good idea anyway because currently sigint is actxing more like sigkill ....

If there is no pidfile in container, does that mean an offline import/export could run while the server is running ?

Except that question regarding offline admin task, the change looks good to me. But I am not container expert at all.

No, because we'll still look for the server backend lock files which still remain :)

@tbordaz The original reporter has tested and this fixes both issues, so if there aren't issues I'd like to commit this and back port through to 1.4.2

No concern regarding the patch. ACK

rebased onto 1ba7370ecc53e52ffe06a7e8afe6fcfc6ca289dc

Pull-Request has been merged by firstyear

Applied 1ba7370ecc53e52ffe06a7e8afe6fcfc6ca289dc to:

0396340ec..a7430ed5a 389-ds-base-1.4.2 -> 389-ds-base-1.4.2

81eb7abe3..3bb6b5032 389-ds-base-1.4.3 -> 389-ds-base-1.4.3

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4137

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.