389-ds-base

#50999 Issue 50640 - Database links: get_monitor() takes 1 positional argument but 2 were given
Closed by spichugi. Opened by mhonek.
mhonek/389-ds-base fix-dsconf-chaining-monitor  into  master

Download 50999.patch

Bug Description:
Cannot call dsconf ... chaining monitor due to invalid call to get_monitor.

FTR: The other issue reported within, for the ... link-delete has already been
fixed in commit c403a39.

Fix Description:
Use _get_link to get the named link, the same way some other functions in the
file do.

Fixes https://pagure.io/389-ds-base/issue/50640

Author: Matus Honek mhonek@redhat.com

Review by: ???

Question: Should I move the definition of _format_monitor to e.g. cli_base?

Question: Should I move the definition of _format_monitor to e.g. cli_base?

There is a format_monitor in monitor.py too. I'm actually using it right now for my dbmon.sh port to dsconf. Check them both out, but sounds like it makes sense to move it to cli_base (assuming the functions are the same)

Ah, sorry, I misnamed. In the question above I actually meant _format_status. And I actually think (since I couldn't find any format_monitor) we are talking about the same thing here. So, I'll go and put it in the cli_base.

1 new commit added

  • Merge and move _format_status to cli_base

@mreynolds So, I probably found out what you meant. Please, have a look at the top commit.

LGTM!

Ah, sorry, I misnamed. In the question above I actually meant _format_status. And I actually think (since I couldn't find any format_monitor) we are talking about the same thing here. So, I'll go and put it in the cli_base.

I knew what you meant, glad you knew what I meant haha

rebased onto f31abde7da3a941147b3dfea032bbbc60305b87f

Pull-Request has been merged by mhonek

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/4052

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.