Description: We ship unused files under src/cockpit/389-console/src. We should clean them up. It includes: static/ and banner.htmp. Also, fix two related lines in index.html and webpack.config.js
https://pagure.io/389-ds-base/issue/50976
Reviewed by: ?
Metadata Update from @spichugi: - Request assigned
What about:
Can these be removed too?
1 new commit added
Remove fonts and images
I was thinking we use it for some custom PF elements but yes, you are right, we don't :) Just removed them and everything looks okay.
Thanks! Please, check once more
Need to remove fonts and images from here, right?
rebased onto f41e1d3fbdd61fc2757070f06f071177722fb258
Ohh.. It is just not my day... Thanks!
Yeah, it will give a warning if we don't remove the lines. But it will pass audit and it will be built successfully. Removed.
audit
ack!
Pull-Request has been merged by spichugi
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This pull request has been cloned to Github as issue and is available here: - https://github.com/389ds/389-ds-base/issues/4030
If you want to continue to work on the PR, please navigate to the github issue, download the patch from the attachments and file a new pull request.
Thank you for understanding. We apologize for all inconvenience.
Pull-Request has been closed by spichugi
Description: We ship unused files under src/cockpit/389-console/src.
We should clean them up. It includes: static/ and banner.htmp.
Also, fix two related lines in index.html and webpack.config.js
https://pagure.io/389-ds-base/issue/50976
Reviewed by: ?