#50932 Issue 50926 - Remove dual spinner and other UI fixes
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base issue50926  into  master

Download 50932.patch

Description:

  • Removed unnecessary spinner when loading the backup table.
  • Removed duplicate ID's from html
  • Revised Create Instance modal to be easier to read
  • Fixed typo in posix winsync fixup task help description
  • Removed unused CSS styles

relates: https://pagure.io/389-ds-base/issue/50926

Reviewed by: ?

Yeah, I guess it is really about a personal taste. :)
I prefer to have less space on the label and more space on the input because it brings the user's attention to the input more.

But I am not opposed the way you have it. So it's up to you.

The rest looks good.

P.S. could you please attach my small diff to your patch too? It fixes the multi loading issue in the Monitor tab... Attaching the file to the issue https://pagure.io/389-ds-base/issue/50926

Yeah, I guess it is really about a personal taste. :)
I prefer to have less space on the label and more space on the input because it brings the user's attention to the input more.
But I am not opposed the way you have it. So it's up to you.

I just don't like when Labels wrap, so I made the margins big enough so that doesn't happen. It makes it more readable and clear IMHO. Plus the input field values coming from DS are not very "long" - we don't need wide input fields to clearly see these values. That's my personal take on it.

I will also get your patch applied, then I think we are finally done with the UI for now :-)

Okay, got your point)

You have my ack.

rebased onto b43ec69c8656a28573b30abef4b8f3a44a8caedc

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3985

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata