#50845 Ticket 50787 - fix implementation of attr unique
Closed by spichugi. Opened by firstyear.
firstyear/389-ds-base 50787-plugin-cls-on-enable  into  master

Download 50845.patch

Bug Description: The implementation of attribute unique relies
on a "plugin per config" which is different to most other
handlings. This creates an exception case to the standard
plugin framework in lib389 that was not correctly handled
in the CLI.

Fix Description: Fix the cli to have the correct customised
variants of the commands to support this plugin's behaviour.

dsconf localhost plugin attr-uniq status uid-test
Plugin 'uid-test' is disabled
dsconf localhost plugin attr-uniq enable uid-test
Successfully enabled the cn=uid-test,cn=plugins,cn=config
dsconf localhost plugin attr-uniq enable uid-test
Plugin 'uid-test' already enabled
dsconf localhost plugin attr-uniq status uid-test
Plugin 'uid-test' is enabled
dsconf localhost plugin attr-uniq disable uid-test
Successfully disabled the cn=uid-test,cn=plugins,cn=config
dsconf localhost plugin attr-uniq disable uid-test
Plugin 'uid-test' already disabled

https://pagure.io/389-ds-base/issue/50787

Author: William Brown william@blackhats.net.au

Review by: ???

@firstyear, just a dummy question instead of specifying the plugin RDN (e.g. uid-test) would it be possible to specify the attributename that is specified in the plugin entry ?

The one logging line uses DN while the one higher up uses RDN. Same for the first function. Should be consistent, right?

@mreynolds It's inconsistent in the generic_* versions, so we are "consistently inconsistent". I think to fix these "naming" outputs in beyond scope here,

@tbordaz No, because you can have multiple plugins doing uid uniq on the same attr via attribute set management, so you have to use the cn ....

rebased onto 493a66449307d703bf53eb3a239d645126b63e09

Pull-Request has been merged by firstyear

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3899

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata