First

Although it seems it is not related to hereby PR, rpmbuild with upstream spec is complaining:

• first

cpio: src/libsds/<::core::macros::assert_eq macros>: Cannot stat: No such file or directory

• then

error: File not found: /home/vagrant/rpmbuild/BUILDROOT/389-ds-base-1.4.3.1-20200120git52fa3f105.fc30.x86_64/usr/lib64/dirsrv/librsds.so

Any idea?

Btw, I was trying to look how you build it at SUSE but the only SPEC I could find seems to build without Rust by default -- is this related?

Second

make -f rpm.mk clean should probably remove the vendor and vendor.tar.gz files as well.

@mhonek I'm trying to resolve the opensuse spec to use rust at the moment. :)

The make clean is a good idea.

I'll also look into those other two reported issues, I have some ideas on this.

Thanks for looking!

I see this error too:

[  576s] original debug info size: 18836kB, size after compression: 12676kB
[  577s] /usr/lib/rpm/sepdebugcrcfix: Updated 45 CRC32s, 0 CRC32s did match.
[  577s] cpio: acl.yy.cpp: Cannot stat: No such file or directory
[  577s] cpio: aclscan.l: Cannot stat: No such file or directory
[  577s] cpio: acltext.y: Cannot stat: No such file or directory
[  577s] cpio: src/libsds/<::core::macros::assert_eq macros>: Cannot stat: No such file or directory
[  577s] 28036 blocks

It doesn't look like it causes a failure though,

I've made a change to the upstream spec, that I'm including in the next commit to fix the .so missing, because the way we construct the .so has changed, so that statement is not needed anymore.

This is the update to the suse spec, but obviously it relies on this commit, so it's not going to have the switch flipped until probably 1.4.3.2.

https://build.opensuse.org/request/show/765973

Anyway, thanks again for the review @mhonek

@mhonek I think last night you said this was all okay?

@mreynolds Can you double check this to please :)

@firstyear Thanks for the updates! LGTM.

Hey sorry, I found a follow up issue due to the rebase with ssotoken, we were missing a single link flag for -lssl and -lcrypto, and thanks to the other ssotoken change it has also changes the cargo.lock to in the workspace. Sorry to make you check again :(

Once this goes in, we'll look at https://pagure.io/389-ds-base/pull-request/50848 :)

Okay, so just for future-changes-consistency I'd rather see here a different comment, like # [profile.release] comes inherited from src/Cargo.toml or something (and same for the other two files of course). But that's minor... Ack.

Yeah, i probably should have done this differently, it's been a bit awkward as it either "all works" or "doesn't", and so getting it to the working state (and testing it) has been a mess :(

Anyway, I'll merge this and hopefully it's less of a schmozzle next time.

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3886

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.