Description:
An unnecessary flag was set in glob() that was resulting in a memory leak in the DS code. Removing this flag eliminated the leak.
Passed ASAN tests
relates: https://pagure.io/389-ds-base/issue/50599
It looks good to me. ACK
Note : We can possibly use flag GLOB_NOSORT that will save processing.
It looks good to me. ACK Note : We can possibly use flag GLOB_NOSORT that will save processing.
We can look into that, but sorting a few files probably doesn't take long and during database recovery performance is not really a big concern (especially the few milliseconds we might save with this flag).
rebased onto cf849cc36fd94358c5b024ddfc421d8b42e59dfc
Pull-Request has been merged by mreynolds
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This pull request has been cloned to Github as issue and is available here: - https://github.com/389ds/389-ds-base/issues/3881
If you want to continue to work on the PR, please navigate to the github issue, download the patch from the attachments and file a new pull request.
Thank you for understanding. We apologize for all inconvenience.
Pull-Request has been closed by spichugi
Description:
An unnecessary flag was set in glob() that was resulting in a memory leak in the DS code. Removing this flag eliminated the leak.
Passed ASAN tests
relates: https://pagure.io/389-ds-base/issue/50599