#50822 Ticket 49624 cont - DB Deadlock on modrdn appears to corrupt database and entry cache
Closed by spichugi. Opened by lkrispen.
lkrispen/389-ds-base t49624cont  into  master

Download 50822.patch

Bug: If there are deadlocks a transaction will be retried. In the case
of modrdn operation there is an error in handling the newsuperior
dn, which has to be reset when the txn is repeated.

Fix: check if the newsuperior in the pblock was changed before the retry and
only then free and reset it.
fix the txn_test_thread to run

Reviewed by: ?

Overall looks good.
Shouldn't be commented that is this case orig_dn_newsuperiordn did not go in the pblock (no retry) and need to be free.

In this case orig_dn_newsuperiordn did got into the pblock so dn_newsuperiordn was duplicated from orig_dn_newsuperiordn.

Except those possibles comments the fix looks good. Ack

rebased onto cd5b3fbc1e2e764a74d65e5bdb847c1f029cf26a

The patch looks good to me. Ack

Same, ack from me.

My test with ASAN passed. Ack!

rebased onto 711b9de13ce13adb5b13c4252cb516db433621b3

Pull-Request has been merged by lkrispen

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3876

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata