389-ds-base

#50797 Issue 49761 - Fix CI test suite issues
Closed by spichugi. Opened by sgouvern.
sgouvern/389-ds-base rhds_44  into  master

Download 50797.patch

Problem Description:
Random failures in test suites/plugins/rootdn_plugin_test.py.
It may occur on slow machines that configuration changes take more or less time to be effective.
The current static timer in the tests does not always plays its role, being difficult to set it to a reasonable and efficient value.

Fix Description:
In all possibly impacted tests, replace time.sleep() by a polling waiting for the configuration changes to be effective before attempting a bind
Fix the get_allow_ip() and get_deny_ip() methods so that they return multiple values, rootdn-deny-ip and rootdn-allow-ip attributes being multi-valued

Relates: https://pagure.io/389-ds-base/issue/49761

Author: sgouvern

Review by: spichugi

There is no need in str() if you already use get_attr_val_utf8 because _utf8 ensures the output type

Why not use actual boolean type here?

1 new commit added

  • Issue 49761 - Fix CI test suite issues

rebased onto cf598118809fd9cafc316769aa12c5f5a7f1fc65

Changes done as suggested.

Please, don't forget to put the updates as a separate commit on top. It makes it easier to see what has changed.

The code looks good to me. Ack.

Sure, I'll put updates as separate in my next PRs. Do you have an example, so that I can see how to do that ?
Thanks for the review !

rebased onto eccc7eac69a60834effaa16b9ac209a2a62a545d

rebased onto 570183b695d8698511e821f5233d68d4cdf41d38

Sure, I'll put updates as separate in my next PRs. Do you have an example, so that I can see how to do that ?
Thanks for the review !

Yeah, you can just commit new changes as a separate commit:

git commit -a -m 'Fix str issue'

And then you can push it to your branch:

git push sgouvernremote rhds_44

And after you get the ack you can do git rebase -i, fix commit message and force push.
Edited by spichugi

@spichugi thanks for the explanation :)

rebased onto 49ccb4d5fa46f39021a1aec9637af329a3aa1c95

Pull-Request has been merged by vashirov

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3851

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.