#50792 Ticket 50727 - change syntax validate by default in 1.4.2
Closed by spichugi. Opened by firstyear.
firstyear/389-ds-base 389-ds-base-1.4.2-default-filter-verify-to-warn  into  389-ds-base-1.4.2

Download 50792.patch

Bug Description: The default syntax validate for 1.4.2 should be changed to
a softer introduction so that admins have time to prepare for the change
of query behaviour in 1.4.3.

Fix Description: Change default in 1.4.2 to warn-invalid, 1.4.3 will
remain as process-safe.

https://pagure.io/389-ds-base/issue/50727

Author: William Brown william@blackhats.net.au

Review by: ???

Output from dsconf config get on a new instance

nsslapd-verify-filter-schema: warn-invalid
nsslapd-versionstring: 389-Directory/1.4.2.5.20191218git60c1831bd

This change is sufficient but I identified an other place where the WARN_SAFE was set as default value (even if it is overwritten later). Do you mind to add the changes in libglobs.c that are present in https://pagure.io/389-ds-base/pull-request/50751#request_diff

Ahhhh I see. When you do a config reset you'll get this value. I'll update to fix that too, good spot.

rebased onto c9984b32618b15035c46cad14016afb477c21904

Updated as per your comments @tbordaz

Thanks for the update. PR looks good to me . ACK

@firstyear, please copy/paste git push message in 50727. thanks

Hey @tbordaz I'm not sure I understand the comment about the git push message?

@firstyear , following the ACK , you are going to push the change of default in 1.4.2.
I was just asking you to update https://pagure.io/389-ds-base/issue/50727 with the commit/push output. It helps to track which fix is in which branch

Ahhh sure, I see :) I'll do this now then :)

rebased onto 32be56b5139a3e84d58c19cf3ee2ee38030fc67f

Pull-Request has been merged by firstyear

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3847

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata