#50697 Issue 50696 - Fix various UI bugs
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base ui_fixes  into  master

Download 50697.patch

https://bugzilla.redhat.com/show_bug.cgi?id=1751004
Bug 1751004 - Log Settings "Create New Log Every" takes non integer as input, it even takes alphabets

https://bugzilla.redhat.com/show_bug.cgi?id=1748349
Bug 1748349 - 'View objectclass' modal dialog doesn't have all controls disabled

https://bugzilla.redhat.com/show_bug.cgi?id=1688614
Bug 1688614 - Chaining Configuration Error: Cockpit had an unexpected internal error

https://bugzilla.redhat.com/show_bug.cgi?id=1748355
Bug 1748355 - LDAPI and Autobind configuration should have a warning

https://bugzilla.redhat.com/show_bug.cgi?id=1751157
Bug 1751157 - Cannot Create Database Link

https://bugzilla.redhat.com/show_bug.cgi?id=1751011
Bug 1751011 - DS instance can be easily destroyed by changing non existing Directory Manager DN

https://bugzilla.redhat.com/show_bug.cgi?id=1688663
Bug 1688663 - Cockpit: Enable Replication failed with error "Failed to add replication manager because the base DN of the entry does not exist"

https://bugzilla.redhat.com/show_bug.cgi?id=1751035
Bug 1751035 - Allow and Deny same Ciphers same time

relates: https://pagure.io/389-ds-base/issue/50696

One really minor thing.

I think, instead of this:

for (let ii = 0; ii < deniedCiphers.length; ii++)

it is better to use this format:

for (let cipher in deniedCiphers)

It is less human error-prone and easier to read in general.

The rest looks good! Ack

One really minor thing.
I think, instead of this:
for (let ii = 0; ii < deniedCiphers.length; ii++)

it is better to use this format:
for (let cipher in deniedCiphers)

I can not use that method because of the way I splice the current array and how I manipulate the index counter. I tried it, doesn't work correctly:

        for (let i = 0; i < availableCiphers.length; i++) {
            for (let ci = 0; ci < values.length; ci++) {
                if (availableCiphers[i] === values[ci]) {
                    availableCiphers.splice(i, 1);
                    i--;
                    break;
                }
            }
        }

The issue is where I do the "i--;", this does not work using your proposed method. So what happens is that the next element in availableCiphers gets skipped if we remove/splice the previous element. There is no way to rewind the index counter using "for in array".

Okay, I see... Then yeah, it doesn't make sense to change.

You have my full ack then!

rebased onto 21f2a06c677b698c612ad17c04081d37ef7c2b1e

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3752

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata