#50658 Issue 50634 - Clean up CLI errors output
Closed by spichugi. Opened by spichugi.
spichugi/389-ds-base error_cleanup  into  master

Download 50658.patch

Description: CLI tools should print human easy readable messages
if something went wrong.
As discussed here: https://pagure.io/389-ds-base/pull-request/50624

Change the CLI error processing so the dict type is always transformed.

https://pagure.io/389-ds-base/issue/50634

Reviewed by: ?

Couldn't we abstract that sequence of several lines that are literally the same into a procedure?

1 new commit added

  • Encupsulate code

Good catch, thanks!

Looks good, thanks!

rebased onto b74ddc0d1656ca2d487141c14d7c3a967a47f8ae

rebased onto a2e3c02ec0cf7ec0f4a500188979d41d276308cc

Pull-Request has been merged by spichugi

This is a security risk, because if an attacker can control any input that becomes put into an error message, it will be run here. This is not safe.

This is a security risk, because if an attacker can control any input that becomes put into an error message, it will be run here. This is not safe.

Could you please provide some examples of a possible attack?..
Looking at the code and at the docstring, it looks safe - https://hg.python.org/cpython/file/tip/Lib/ast.py#l40

My apologies - eval normal leads to horrible things, but indeed you chose the safe one! Okay, could you comment (with the oneline rule maybe?) about this discussion above the use of literal_eval incase this discussion point comes up in a security review?

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3713

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata