Maybe you can change the variable names to be most descriptive? It's not immediately clear what "e_" vs "v_" means. Maybe we could change it to "value_set", "entry_set", "value_add", "value_rem"? It's minor I know, but makes it easier to read for others.

Maybe you can change the variable names to be most descriptive? It's not immediately clear what "e_" vs "v_" means. Maybe we could change it to "value_set", "entry_set", "value_add", "value_rem"? It's minor I know, but makes it easier to read for others.

Other than that, LGTM

I'll change those value names, you're right, I shouldn't be lazy and making it easier for people is important.

I'll merge once they are updated :)

This change introduced a regression: https://pagure.io/389-ds-base/issue/50638

@firstyear, please create an issue/ticket for changes you're doing and mention it in the commit. If a change introduces a regression (like this one), it's not possible to reopen a PR, but it's possible to reopen an issue/ticket. And it's also easier to track down changes in a git log. Thanks!

I didn't realise it would cause a regression, but yes this is a good point. I'll fix that error today.

@firstyear, please review my attempt to fix it: https://pagure.io/389-ds-base/pull-request/50639

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3687

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.