389-ds-base

#50630 Issue 49850 - ldbm_get_nonleaf_ids() slow for databases with many non-leaf entries
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base import-perf  into  master

Download 50630.patch

Bug Description:

The logs from an LDIF import indicated that gathering non-leaf IDs for creating the ancestorid index took an enormous amount of time over 10hrs. The root cause is that the parentid index btree ordering is lexical, but the IDList being built up from it is sorted numerically. In the existing code, the IDList is maintained in constantly sorted order by idl_insert().

Fix Description:

ldbm_get_nonleaf_ids() switches to idl_append_extend() instead idl_insert() for building up the IDList and then sorts the result only once, using qsort with idl_sort_cmp, after the entire list has been gathered.

"The improvement on identical hardware is for the operation to take 10 seconds rather than 10 hours" - Thomas

Patch Author: Thomas Lackey telackey@bozemanpass.com Thanks for the great contribution!!!

relates: https://pagure.io/389-ds-base/issue/49850

The patch look good to me. Ack

Ack from me too

Pull-Request has been closed by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3685

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.