Bug Description: SUSE doesn't have the python-selinux module by default, so this tool crashes as it can't find the python module for import.
Fix Description: ATtempt to import the library, and on failure return false for enabled.
https://pagure.io/389-ds-base/issue/50622
Author: William Brown william@blackhats.net.au
Review by: ???
Shouldn't "import semange" also be here?
No, because we don't call anything from semanage .... I don't know why it was added in the first place :)
LGTM iff we don't care about missing python selinux module while selinux is actually running on the system. But this only affects the Perl tools, right?
@mhonek Well, lib389 deps on python-selinux on RHEL/Fedora, but not on SUSE, so the missing module is fine. That's a package maintainer/integrator problem I think, not a lib389 one.
Yes this only affects the perl tools, but I will need to backport this to 1.4.0/1.4.1 because of grumble past administrative mistakes requiring me to support this ....
@mreynolds Are you okay with me pushing this patch to the 1.4.0 and 1.4.1 branches?
rebased onto 54df38eeba00b97009e978c0030110f67825215a
Pull-Request has been merged by firstyear
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This pull request has been cloned to Github as issue and is available here: - https://github.com/389ds/389-ds-base/issues/3678
If you want to continue to work on the PR, please navigate to the github issue, download the patch from the attachments and file a new pull request.
Thank you for understanding. We apologize for all inconvenience.
Pull-Request has been closed by spichugi
Bug Description: SUSE doesn't have the python-selinux module by
default, so this tool crashes as it can't find the python
module for import.
Fix Description: ATtempt to import the library, and on failure
return false for enabled.
https://pagure.io/389-ds-base/issue/50622
Author: William Brown william@blackhats.net.au
Review by: ???