#50456 Issue 50454 - Fix Cockpit UI branding
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base issue50454  into  master

Download 50456.patch

Bug Description:

On RHEL we still displayed "389 Directory Server" in the Cockpit vertical navigation panel instead of "Red Hat Directory Server".

Fix Description:

Create a new manifest & XML files just for RHEL and in the specfile replace the those files as needed for RHEL or non-RHEL package packages.

https://pagure.io/389-ds-base/issue/50454

I think it would be better to put branding files to RHEL dist-git: patch for Makefile.am plus xml and json files. Or even a single patch that will rename the xml and replace with RHDS branding. This way upstream will be distro-agnostic.

I have to double what Viktor said. We should separate the two, even though it means a bit more burden downstream. Additionally, AFAIR there is already some branding content in place which should be moved as well, or did we already do that...?

After discussing with Viktor I'm going to remove all the special branding files, and simply do a sed replacement of "389 Directory Server" to "Red Hat Directory Server" in the downstream RHEL specfile.

rebased onto 33fe99a96c67fe6d21f52ed508c181efbd6bbe60

Looks good on both Fedora and RHEL8. You have my ack!

rebased onto f6e24e47b5599bbf53fdbbb73dd2b7bd7d8a9fc9

rebased onto 5c0198d998a66fad123231dbb103812c1e16046f

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3514

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata