389-ds-base

#50441 Ticket 50439 - Update docker integration to work out of source directory
Closed by spichugi. Opened by firstyear.
firstyear/389-ds-base xxxxx-docker-suse-source  into  master

Download 50441.patch

Bug Description: Docker did not function in some cases, and we had to wait for
releases via rpm.

Fix Description: This adds the support to build from source into the tree
so that we can build and test git master. This also resolves a var/run
issue in the image, as well as some other minor python cleaning such
as handling sigchld to act as init.

https://pagure.io/389-ds-base/issue/50439

Author: William Brown william@blackhats.net.au

Review by: ???

It looks a bit weird to me that you removed the whole Docker file for Fedora and replaced it with SUSE one...
I have nothing against SUSE, of course, but I think we shouldn't remove Fedora support but fix it instead.
Or do I miss something?

I don't build on fedora, so I'm not going to update it - the fedora version was well outdated, broken, didn't work properly .... so I wasn't going to update it.

It would be easy to add a fedora one in parallel, which is why I named the folders as such :)

I don't build on fedora, so I'm not going to update it - the fedora version was well outdated, broken, didn't work properly .... so I wasn't going to update it.
It would be easy to add a fedora one in parallel, which is why I named the folders as such :)

Ok, then I think it is reasonable to not delete the existing Fedora Doker file but create an issue that it is outdated...

It would be easier to just start fresh ... You'll be rewriting the whole thing anyway, so delete or fix is much over muchness .... someone from the fedora side needs to do the work, and I'm certainly happy to advise, but the suse version is probably a guide you could use.

It would be easier to just start fresh ... You'll be rewriting the whole thing anyway, so delete or fix is much over muchness .... someone from the fedora side needs to do the work, and I'm certainly happy to advise, but the suse version is probably a guide you could use.

Sure, I agree with you.
My point is that we create unnecessary confusion by deleting something in the PR which is about adding different stuff.

I think we should not mix things up.
If this PR is about SUSE Docker file and building from a source directory tree, it should be only about it.
The second PR will remove the old one and will add a new Fedora Docker file. This will result in a clean git-log history.

Okay, I'll change the PR to reflect this then.

rebased onto d7d207e414545cd7d8cd24e29036cd17ff9c0996

Okay, restored the fedora file, and renamed it to make it clearer what it is.

I haven't tested on SUSE (I trust your judgement here) but the rest looks good!
You have my ack:)

rebased onto 5c6ffae12ea1f503e1f032aebb73b15a338c8415

Pull-Request has been merged by firstyear

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3499

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.