#50408 Issue: 48851 - investigate and port TET matching rules filter tests(vfilter simple)
Closed by spichugi. Opened by aborah.
aborah/389-ds-base simple  into  master

Download 50408.patch

Investigate and port TET matching rules filter tests(vfilter simple)

Relates: https://pagure.io/389-ds-base/issue/48851

Author: aborah

Reviewed by: ???

rebased onto 722abc17a9a4a9a24fbe5181480e2579bf90ee86

Please, separate worlds properly while using https://en.wikipedia.org/wiki/Snake_case

Once again, you create not only users here

It is hard to read at that point.
It will be better if you'll use proper parameter names in the method (maybe, you can make it a function?)

Also, please, avoid these value[0], value[1] approach. It is not really descriptive.
You can use this approach instead:
for attr, value in [YOUR_LIST]:

1 new commit added

  • Fixing Simon's comments

@spichugi changes are done as per your suggestion

Could you please rename functions properly? They create users, right?

snake_case

snake_case

Looks like DS is not accept this value except facsimiletelephonenumber

ldap.OBJECT_CLASS_VIOLATION: {'desc': 'Object class violation', 'info': 'attribute "facsimile_telephonenumber" not allowed\n'}

but we can change is other places , as done

1 new commit added

  • Fixing Simon's comments 2

@spichugi changes are done as per your suggestion

It is not a fixture so it will be better if it'll have a verb. Also, please, fix other functions

telephonenumber should be divided too

snake_case

Attribute names are not allowed with the underscore. What are you suggesting exactly?

It is not a fixture so it will be better if it'll have a verb. Also, please, fix other functions

Can you please elaborate , i am confused what's wrong with the name here . I am not getting any error with pylint

snake_case

Attribute names are not allowed with the underscore. What are you suggesting exactly?

I was talking about variable names, of course. I see no reason to keep them the same as attribute names.
It will be more easy to read if they are in snake_case.
Words intelephonenumber are not divided. And realvalue too.

I understand it can look as nitpicking but I'd like to mention it once now to make the code more readable in the future. (initially, it was facsimiletelephonenumber which is tedious, IMO)

It is not a fixture so it will be better if it'll have a verb. Also, please, fix other functions

Can you please elaborate , i am confused what's wrong with the name here . I am not getting any error with pylint

Functions (especially in tests) makes more sense to name with a verb. Like create_users.
Like this, it is more clear about what the function does. If you name it just unknown_lang, it is pretty unclear.

1 new commit added

  • Fixing Simon's comments 2

@spichugi changes are done as per your suggestion

I think it makes sense to mention the negative point of the test case here, in the steps.

The rest LGTM

1 new commit added

  • Fixing Simon's comments 4

5 new commits added

  • Issue: 48851 - investigate and port TET matching rules filter tests(vfilter simple)
  • Fixing Simon's comments 2
  • Fixing Simon's comments 2
  • Fixing Simon's comments
  • Issue: 48851 - investigate and port TET matching rules filter tests(vfilter simple)

rebased onto 121fbd117721f3c3048d10a2478d7a5a088ae498

rebased onto c82f238e74f6321e34cba6a07ee8db40aff45a9f

I think it would be better to name the variable as 'new_schema' or 'my_schema' etc., because 'schama' can be easily mistyped and cause collision.

rebased onto 43060f11375f6b0f957f74a8117496c5aa225b9c

I think it would be better to name the variable as 'new_schema' or 'my_schema' etc., because 'schama' can be easily mistyped and cause collision.

changed

Maybe Pagure is broken but I don't see the change. I still see schama

Pylint says it has a trailing whitespace

rebased onto aa2649fa0c7eb412e1714bb56cfdd4bbf812f613

@spichugi changes are done as per your suggestion

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3466

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata