389-ds-base

#50386 Issue: 48851 - investigate and port TET matching rules filter tests(vfilter_ld)
Closed by spichugi. Opened by aborah.
aborah/389-ds-base ld  into  master

Download 50386.patch

investigate and port TET matching rules filter tests(vfilter_ld)

https://pagure.io/389-ds-base/issue/48851

Reviewed by: ???

Name is misleading. It creates not only users but also - Organisational Units and Schema definitions.

It could be in a more human-readable format.

Why did you place the constants after the fixture definition? The common convention is to put it after the imports.
Edited by spichugi

Why did you put it like this? As far as I see, FILTER_NS, FILTER_HALL, FILTER_L are used only once - here.
I think it would be more readable if you specify them all together just here - in FILTER_COMBINE

you called it FILTER_TAL_MT but it doesn't have TAL

1 new commit added

  • Fixing Simon's comments .

@spichugi , changes are done as per your suggestion

Edited by aborah

1 new commit added

  • Fixing Simon's comments 2

@spichugi , changes are done as per your suggestion

Your test suite is named with a suffix ld. What is it? Could you please make it more obvious?

Your test suite is named with a suffix ld. What is it? Could you please make it more obvious?

Can you please suggest a name , i will rename as you wish

Your test suite is named with a suffix ld. What is it? Could you please make it more obvious?

Can you please suggest a name , i will rename as you wish

Probably, it will be easier if you'll do it by yourself because you have the full view of all filter test suites that you have ported and all of that will be ported in the future.

But I can suggest a name, no problem. But then please, prepare a full list of filter test suites with descriptions so I can get a better understanding how to unite them in the groups and name them accordingly.

1 new commit added

  • Renamed the script to vfilter_attribute_test.py

@spichugi Renamed the script to vfilter_attribute_test.py

LGTM
Please, rebase and don't forget to change the commit message

rebased onto 088bb0be3ee4f41337ddf9533f336508f1012be6

4 new commits added

  • Issue: 48851 - investigate and port TET matching rules filter tests(vfilter_ld)
  • Fixing Simon's comments 2
  • Fixing Simon's comments .
  • Issue: 48851 - investigate and port TET matching rules filter tests(vfilter_ld)

rebased onto 430ec8c4168b4732f2f31cfc8a39e1a5f3fe62f1

rebased onto 6cf1689fb8bdd246681ba37f1e06075515948316

rebased onto 68e8b7aaba6d752236a85e275568264c9ac62b8d

rebased onto cf01e3b4a9ee01c94df23c21d52c7190fecb315c

Pull-Request has been merged by vashirov

I probably wasn't clear enough, sorry.
I meant that you need to change the name of the test case in the commit message.

But also, please, don't forget to check everything twice before the final rebase.

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3444

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.