Bug Description: The recent removal of support for Mozilla's ldapsdk in b770ac7 left behind some unused variables.
Fix Description: Remove the unused variables from the code base.
Author: Hugh McMaster hugh.mcmaster@outlook.com
Review by: ???
I have no issue with this, Ack. @mreynolds want to double check for me?
Thanks, @firstyear. @mreynolds, do you have any feedback?
I need to make sure it doesn't break any builds on Fedora and RHEL. I'll get that done today...
@hmc can you change the commit message to start with this as the first line:
Ticket 49730 - Remove unused Mozilla ldapsdk variables
You can see an example of the expected commit text here:
http://www.port389.org/docs/389ds/contributing.html#getting-the-patch-ready
Otherwise this looks good to me, and it passed my tests! Thanks for the contribution!
Thanks for the PR. These indeed may go as well, my bad. You've my ack, too.
rebased onto 22da3359bdcbe8f4aa4afcd9ad9feb4cf1864a45
@mreynolds, I've updated the commit message. Please let me know if you need any further changes to it.
@mhonek, thanks.
@hmc Sorry for the delay... Could you please rebase once more onto current master? I'll merge it right after. Thanks!
rebased onto 08a6aadc924103b045c4dd4b4ef6b56952252257
@mhonek, no problem -- done! :-)
Pull-Request has been merged by mhonek
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This pull request has been cloned to Github as issue and is available here: - https://github.com/389ds/389-ds-base/issues/3440
If you want to continue to work on the PR, please navigate to the github issue, download the patch from the attachments and file a new pull request.
Thank you for understanding. We apologize for all inconvenience.
Pull-Request has been closed by spichugi
Bug Description:
The recent removal of support for Mozilla's ldapsdk in b770ac7
left behind some unused variables.
Fix Description:
Remove the unused variables from the code base.
Author: Hugh McMaster hugh.mcmaster@outlook.com
Review by: ???