investigate and port TET matching rules filter tests(scanlimit)
https://pagure.io/389-ds-base/issue/49730
Author: abprah
Reviewed by: ???
rebased onto 443d8301a30f11e73c9da0717286e21399b29fbe
OrganizationalUnit is unused import. Please, don't forget to run pylint, it tells these things
pylint
Typo
Looks like this step is not described in the docstring. Or do I miss something?
It is not a default log level. Please, get the initial log level and then set it back in the end
You are not creating any instance or entries in this test case
I have merged the last test case with second one it was part of it was checking indexing works after restart
1 new commit added
Fixing Simon's comments
@spichugi changes are done as per your suggestion
You are not creating an instance in the test case itselt. It is already mentioned in Setup
Why do you define this function here and not in the outer scope?
Fixing Simon's comments 2
I was asking the question to understand your way of thought :)
Personally, I think it makes sense to put the content of the function here because it is used only once.
As I mentioned before, please, get the previous value and then reset it back at the end of the test case.
Fixing Simon's comments 3
Please, wrap whole part of the test in which you change nsslapd-errorlog-level with try: and finally:, and reset the attribute to the original value in the finally: section. This makes sure the value is always re-set.
nsslapd-errorlog-level
try:
finally:
Fixing Matus Honek's comments
@mhonek changes are done as per your suggestion
@aborah Not sure why you moved the point where the value is reset but if you are sure this is ok then I am fine with it. The test passes for me. LGTM.
@spichugi ACK?
Sure, ACK Please, squash the commits, rebase and we can merge
rebased onto 3c0e8abe3fcce9f7811571160af88d8a84e967c8
rebased onto fc15f9183b752ef2531e747eab1efe472820b43a
rebased onto 96731e1bc7d08e5b8fd76aeb76b4a7c772df3a1d
rebased onto fcf31dd6662bd4f3b734b1752e783c4dbe35353e
rebased onto db29fc2d94bf5e49b0c1d64bee89d2cb94b8d782
Pull-Request has been merged by vashirov
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This pull request has been cloned to Github as issue and is available here: - https://github.com/389ds/389-ds-base/issues/3410
If you want to continue to work on the PR, please navigate to the github issue, download the patch from the attachments and file a new pull request.
Thank you for understanding. We apologize for all inconvenience.
Pull-Request has been closed by spichugi
investigate and port TET matching rules filter tests(scanlimit)
https://pagure.io/389-ds-base/issue/49730
Author: abprah
Reviewed by: ???