Description: Port ACI test suit from TET to python3(userattr)
Fixes https://pagure.io/389-ds-base/issue/50112
Author: aborah
Reviewed by: ???
rebased onto da49e6ae9e72f548c80f8335dcb408a63c54b1d1
rebased onto b0a34c863af93b20563426e7f71ddc9026f81b36
rebased onto 7af084b04f057ad5b1b746cd3a17dc5efcd4840c
The three bottom test functions are almost identical. Please, squash them into one parametrized test.
rebased onto 9862dd822c4aa287be131b8920348972fa9fc144
@mhonek changes are done as per your suggestion
Please, do not use 'rebase-force-push'. Check this for details - https://github.com/marcus2376/389wiki/blob/master/docs/389ds/contributing.md#getting-the-patch-ready
The name is confusing. Should be ou_inheritance
ou_inheritance
Everything, besides target and userattr, is constant. Please, use some constant to avoid repetition. It will increase readability
target
userattr
constant
Everything, besides userattr here, is constant. Please, use some constant to avoid repetition. It will increase readability
3 new commits added
Merge branch 'userattr' of ssh://pagure.io/forks/aborah/389-ds-base into userattr
Issue: 50112 - Port ACI test suit from TET to python3(userattr) Simon comments fixed
Issue: 50112 - Port ACI test suit from TET to python3(userattr)
@spichugi changes are done as per your suggestion
2 new commits added
Pull-Request has been closed by aborah
Pull-Request has been reopened by vashirov
rebased onto aae34b0cdb5722d4b7b48d401e40a5c1bd49d86f
rebased onto 0ff3130cf1c12aee32482d9309347b6a72814052
It is not what I meant... (targetattr=*)(version 3.0; aci "Inheritance aci"; allow(all) is constant. You can put it to some variable and then use it everywhere
(targetattr=*)(version 3.0; aci "Inheritance aci"; allow(all)
This code has a constant part too
rebased onto f5d15c071b948ca429459765069ed4d8eed94234
Please, do not use 'rebase-force-push'.
ErrorLog is unused
Besides that, LGTM
Please, create an additional separate commit for the change, I'll set ack and then you can do interactive rebase in the end.
1 new commit added
Fixed Simon's Comment
Great, thanks! We can merge it after you'll do
git rebase -i HEAD~2 git push myfork --force-with-lease
rebased onto a8bc2e33573039b6d9c3fb84257442e6e5fedb82
Pull-Request has been merged by spichugi
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This pull request has been cloned to Github as issue and is available here: - https://github.com/389ds/389-ds-base/issues/3395
If you want to continue to work on the PR, please navigate to the github issue, download the patch from the attachments and file a new pull request.
Thank you for understanding. We apologize for all inconvenience.
Pull-Request has been closed by spichugi
Description: Port ACI test suit from TET to python3(userattr)
Fixes https://pagure.io/389-ds-base/issue/50112
Author: aborah
Reviewed by: ???