389-ds-base

#50293 Issue 50292 - Fix Plugin CLI and UI issues
Closed by spichugi. Opened by spichugi.
spichugi/389-ds-base plugin_cli_fix  into  master

Download 50293.patch

Description: Fix 'All plugins' tab rendering issue.
Fix nsds5replicalastinitstatus typo.
Fix generic_object_add logic for cases when RDN is in props and BaseDN is supplied.
Add Posix Winsync API plugin
Add PAM PTA plugin
Fix underscore issues in plugin arguments.
Fix Linked Attribute plugin Fixup task arguments and name.

https://pagure.io/389-ds-base/issue/50292

Reviewed by: ?

Looks good. One thing, the logging issue has been fixed so we can stop using "print" and start using "log.info" were applicable.

Ack!

Why not just change the error message instead of the logic?L

Wait, I thought we didn't support winsync anymore ...?

Is linkdn required? If so, it shouldn't be optional.

rebased onto 882e091710a316755e52cb13003a37cf8c116ecc

Looks good. One thing, the logging issue has been fixed so we can stop using "print" and start using "log.info" were applicable.

Done

Why not just change the error message instead of the logic?L

There was an error with the old code (ValueError when only basedn and props were specified). And the previous logic doesn't make much sense... The new one is more clear and the error is fixed with it.

Wait, I thought we didn't support winsync anymore ...?

@mreynolds said that we need the plugin CLI/UI for this one for now.

Is linkdn required? If so, it shouldn't be optional.

It is optional, actually. If this attribute is not set on the task entry, then all configured linked attributes are updated.
Edited by spichugi

Wait, I thought we didn't support winsync anymore ...?

We absolutely still support winsync/passSync

Wait, I thought we didn't support winsync anymore ...?

We absolutely still support winsync/passSync

Today I learnt :)

LGTM

rebased onto 09965c45ed718595ecbd5804d00648b53123014c

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3352

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.