Please do not review this until PR 50258 is merged...

But I really really want to review it .... ;)

But I really really want to review it .... ;)

Hehe, its actually a much larger patch I just haven't rebase yet. I redoing the entire pwp suite of tests, but I need to fix my CLI work first :-(

No problems, I'm just starting the 50258 review now

Patch is ready for review, but you need to revert this commit in master branch to test it:

commit e580506d52eed2c07a093026095ad6107b2ee8d5

Once "Ticket 49873 - Contention on virtual attribute lookup" is finally fixed that revert will not be required to run this patch

Assuming this comment is intentional?

I think this might throw the _s api warning, you could use "dm = DirectoryManager(inst).bind()", but also to keep in mind, when you do a "conn = user.bind()", that makes a new ldap connection, so the original inst connection is NOT alterted/reset so dm keeps working there.

y_o_l_o c_o_o_l f_o_r_m_a_t :P
(I actually have no issue with this, just funny formatting)

Okay, looks pretty good to me. Some minor comments, but great stuff :)

I need to remove this...

Assuming this comment is intentional?

I think I was debugging something, it should probably be removed

@firstyear changes made, and the bind functions do not complain, please review...

FYI to run the patch you need to revert commit e580506 for the time being

Awesome! Thanks man, I think this looks good. Ack :)

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3315

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.