389-ds-base

#50247 Issue 50246 - Fix the regression in old control tools
Closed by spichugi. Opened by spichugi.
spichugi/389-ds-base old_ctl_fix  into  master

Download 50247.patch

Bug Description: The old control tools - status-dirsrv, start-dirsrv,
stop-dirsrv, restart-dirsrv stopped working properly after
the /etc/sysconfig/dirsrv removal.

Fix Description: Make them the direct systemctl command wrappers and
don't look for instances in /etc/sysconfig/dirsrvfix stuff

Also, remove the dragon warning because it breaks the QE test reports
when we run all the tests (we don't use DEBUGGING mode there
because it doesn't remove the instances).
The deprication warning should be enough for now.

https://pagure.io/389-ds-base/issue/50246

Reviewed by: ?

rebased onto c6c5ca3822904dd5e354071069ffec4d077b9d73

This is here because people are not reading the warnings still on new developments, and they absolutely need to be told that what they are doing is wrong.

Additionally, if you have a CLI tool and you hit this error, something is wrong.

If you see it in pytest, run with DEBUGGING=True

Please add --no-pager here to avoid paging with the recent versions of systemd.

This is here because people are not reading the warnings still on new developments, and they absolutely need to be told that what they are doing is wrong.

Please do not present your opinions and assumptions as facts. Some people do read the warnings and work on fixing the issues. Having dragons and other silly comments do not help, they just blow up on your screen and introduce a lot of noise. Let's work in professional manner and treat users and developers with respect.

This is here because people are not reading the warnings still on new developments, and they absolutely need to be told that what they are doing is wrong.

Please do not present your opinions and assumptions as facts. Some people do read the warnings and work on fixing the issues. Having dragons and other silly comments do not help, they just blow up on your screen and introduce a lot of noise. Let's work in professional manner and treat users and developers with respect.

+1

1 new commit added

  • Fix pager status part

We only use CONF_SERVER_ID. Can we import just that, not everything?

Just fix the English here, please: ... will be removed ...

I guess we really don't want to have any possibility (even accidental) of dragons ascii art in the final product. From the code POV I hope we can do better than just showing dragons - open an issue and fix the areas that use this incorrectly one by one (maybe it will be tedious but worth it).

1 new commit added

  • Fix minor issue in Python part

LGTM

rebased onto c6054d12856c8789a778bde19b7e31e7e84e531b

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3306

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.