#50196 Ticket 50195 - improve selinux error messages in interactive
Closed by spichugi. Opened by firstyear.
firstyear/389-ds-base 50195-interactive-selinux  into  master

Download 50196.patch

Bug Description: During an interactive install, the selinux
module if not found would produce many error messages that
were not necessary.

Fix Description: Warn the user at the start of the install
that selinux isn't found, and allow them to continue

https://pagure.io/389-ds-base/issue/50195

Author: William Brown william@blackhats.net.au

Review by: ???

dirsrvtests/tests/suites/basic/basic_test.py::test_dscreate fails on our testing environment (F29):

Port 3636 was already labelled with: (servistaitsm_port_t)  Please choose a different port number

Should be :returns: bool (Sphinx docs https://thomas-cokelaer.info/tutorials/sphinx/rest_syntax.html )

rebased onto dc715bf0e19d954f1e6dec13e359c516bd67df6e

@spichugi If you look, my patch doesn't cause that breakage ... it was already broken. I will fix it in 50198.

Anyway, I have fixed the returns string for you :)

Sorry, missed it in the first review. It should accept uppercase too.

Otherwise, looks good to me!

rebased onto d8a94c288f8bf31525f2634d432efdb0376b2d04

Pull-Request has been merged by firstyear

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3255

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata