389-ds-base

#50124 Issue 50122 - Selinux test for presence
Closed by spichugi. Opened by firstyear.
firstyear/389-ds-base 50122-selinux-calls  into  master

Download 50124.patch

Description: Selinux is not present on all systems. Trying to
import python-selinux when it's not available fails, but we
can not guarantee that the with_selinux flag to defaults is
correct because some systems build with selinux but may not
have it enabled. We should check if we can access the tools
instead, and skip them (with warnings) if we can't make changes

https://pagure.io/389-ds-base/issue/50122

Reviewed by: ???

rebased onto 6409b0d070f662125009f920b4bf592f85a89222

This is wrong. If the port is a default port we should return and not proceed because it is already labelled. This just logs an incorrect message about the port and continues. This function will now fail if you are using one of the default ports.

I'm going to double check, but I'm pretty sure I didn't change the logic. Perhaps I did? It would make more sense as to why I was so confused about this ....

Indeed, I inverted the logic. Good catch! It would seem I confused myself :)

rebased onto accc879fdfa6c21a3c715f25d14937aa3552be71

You still need to "return" here :)

rebased onto 28223f7d8050dcd0d23829c0608a4c9b54970ae9

I'm doing a stunning job so far on my return aren't I :)

Anyway, fixed, please review :)

I'm doing a stunning job so far on my return aren't I :)

Perhaps you are a little RUSTy? :-D

Looks good now, ack!

I'm very rusty indeed :)

Merging now :)

rebased onto afdf3deb3a7aea0a6f6d56ee05f48df14ee6d5d9

rebased onto a9ed1e6ae1dfd7427129819c8f416e436caa69c5

Pull-Request has been merged by firstyear

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3183

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.