389-ds-base

#50074 Issue 50071 - Set ports in local_simple_allocate function
Closed by spichugi. Opened by spichugi.
spichugi/389-ds-base local_allocate_ports  into  master

Download 50074.patch

Description: remove_ds_instance function require DirSrv
object having port and sslport defined for semanage remove
label operation. We should set it in local_simple_allocate too.
Fix DSEldif.get function so it returns a list instead of a view
(Python 3 change).

https://pagure.io/389-ds-base/issue/50071

Reviewed by: ?

The patch looks good. But if nsslapd-port is not found in dse.ldif, then 'int(None)' may return an exception. Should not test 'port' ?

I'd just do self.sslport = int(sslport) if sslport else None. Same for the self.port as Thierry suggested.

rebased onto d4f39c4a1f058c1b28122dc5519e550f341f82c0

Ack for d4f39c4, thanks for the changes!

rebased onto 1698dd8e89b8d11be94c547c194e7a455ffd42a0

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3133

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.