#50000 Issue 49999 - Integrate React structure into cockpit-389-ds
Closed by spichugi. Opened by spichugi.
spichugi/389-ds-base react_refactor  into  master

Download 50000.patch

Description: Refactor the existing 389-console Cockpit plugin structure
so it uses React, Babel, Eslint.

Reviewed by: ?

https://pagure.io/389-ds-base/issue/49999

Is this "make" supposed to be commented out?

Is this "make" supposed to be commented out?

Yes, I'll remove it.
I was experimenting but apperently it is better to use install-data-hook for copying the cockpit_dist files on 'make install'.

Everything seems to work, ack!

rebased onto a69c3616bf926d79f21805e8bbb6fe84574002c0

rebased

rebased onto 8d60265f658d46feba5872d8943678dcbfda83e6

Its working much better! Ack

rebased onto b6808f633725d6a495d66fcad0b998b3c03840f4

rebased onto 51af3e5069ee4cee30e2f929b48bef4e56940d7c

Pull-Request has been merged by spichugi

On a workspace were src/cockpit/389-console/cockpit_dist did not exist before the build. I got 'Not such file or directory'.
After creating the directory, it built successfully.
I do not know where it should be created

On a workspace were src/cockpit/389-console/cockpit_dist did not exist before the build. I got 'Not such file or directory'.
After creating the directory, it built successfully.
I do not know where it should be created

I will address it in my next PR. Thank you!

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3059

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata