389-ds-base

#49948 Issue 49947 - Coverity: 389-ds-base-1.4.0.16.20180905git8ff8cb8
Closed by spichugi. Opened by mhonek.
mhonek/389-ds-base covfix-2018-09-05  into  master

Download 49948.patch

Bugs and fixes description:
- 15607:
- in lib389/suffix.py: Structurally dead code
- 15604:
- in bug_harness.py: Null dereference
+ solved by removing the file as it is unused and outdated
- additionally, remove the static_var decorator definition as it
is not used anyway any more
- 15754:
- in pwdPolicy_syntax_test.py: fix typo in identifier
+ Fix log msg in file pw.c
- 17046, 17061, 17063, 17069, 17084:
- in backend_test and backendLegacy_test: fix use before NULL check
- 17473:
- in lib389/init.py: Identical code in different branches
+ removed the wrapper altogether as we don't support Python2 any more
- replace SafeConfigParser with ConfigParser for it has been just an
alias since Python 3.2 and will be removed in the future

https://pagure.io/389-ds-base/issue/49947

Author: mhonek

Review by: ???

Hey there,

What does this bug_harness file do? What's it's purpose? Thanks :)

The code looks good to me! The tests pass. You have my ack.

https://pagure.io/fork/mhonek/389-ds-base/blob/ba61344679a7df26e3f1b14bcd218bfe6f5f9592/f/src/lib389/bug_harness.py
It is a harness wrapper around DSAdmin tools which we don't have.
I agree with Matus, there is no point in keeping it.

@firstyear Sorry I've not responded (and glad Simon did). I'm genuinely missing a notification about your comment in my mail client. :(

rebased onto 6030eaa150de706437ade5299a2880cf6830f7ea

rebased onto 4f118f428c24172fca06e9d07e71cad85241bf6e

Pull-Request has been merged by mhonek

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3007

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.