#49882 49881 - Missing check for crack.h
Closed by spichugi. Opened by firstyear.
firstyear/389-ds-base 49881-crack-check  into  master

Download 49882.patch

A check for crack.h is missing from configure.ac. Add it.

https://pagure.io/389-ds-base/issue/49881

Author: William Brown william@blackhats.net.au

we have a BuildRequires cracklib-devel - not sure why this isn' t working for you. Anyway I'm fine with this patch though, ack.

Buildrequires is in the RPM, not the configure check. So if you are building outside the rpm environment, you don't know the dep is missing until partway in the build. It's just good hygiene to do these checks to fail fast :)

Pull-Request has been merged by firstyear

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2941

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata