389-ds-base

#49812 Ticket 49811 - Update man pages
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base ticket49811  into  master

Download 49812.patch

Bug Description: A recent man page scan revealed several errors and warnings.

Fix Description: Added missing man pages, fixed syntax issues, and added
new man pages for config files.

              Also added dynamic man page creation for the lib389 CLI tools
              using python-argparse-manpages

https://pagure.io/389-ds-base/issue/49811

Reviewed by: ?

rebased onto e6e00bba05ed5a9e45b274565136caddfd13788f

Man pages for config files should be in man5: 

+ %{_mandir}/man8/99user.ldif.8.gz
+ %{_mandir}/man8/certmap.conf.8.gz
+ %{_mandir}/man8/template-initconfig.8.gz
+ %{_mandir}/man8/slapd-collations.conf.8.gz
+ %{_mandir}/man8/dirsrv.8.gz
+ %{_mandir}/man8/dirsrv.systemd.8.gz

And since you're changing 389-ds-base.spec.in, could you please remove requires for tcp_wrappers and change python3-pyldap to python-ldap?

The rest LGTM.

rebased onto 42e663603eb4f99bef947eb852d4adf59bd6f749

Revised man pages, thanks @vashirov !

Please review...

LGTM!

We also need argcomplete in BuildRequires.
And these:

BuildRequires: python%{python3_pkgversion}-ldap
BuildRequires: python%{python3_pkgversion}-six
BuildRequires: python%{python3_pkgversion}-pyasn1
BuildRequires: python%{python3_pkgversion}-pyasn1-modules
BuildRequires: python%{python3_pkgversion}-dateutil
BuildRequires: python%{python3_pkgversion}-argcomplete

Otherwise build in mock fails.

This broke installation of lib389 using pip:

[root@server ds]# pip3 install src/lib389/
Processing ./src/lib389
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-req-build-1epms9fu/setup.py", line 17, in <module>
        from build_manpages import build_manpages
    ModuleNotFoundError: No module named 'build_manpages'
    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-req-build-1epms9fu/

rebased onto 96ad23aa5340d083a818ad68ea57875814ec8b65

Everything seems to be working for me with the latest commit. Please review one last time. Thanks!

Mock build works and I can install lib389 using pip3 from the repo, ack.

LGTM too

rebased onto 0d9886e7524277a0ffd1a925dbdff2e0e01ae874

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2871

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.