#49771 Issue 49640 - Errors about PBKDF2 password storage plugin at server startup
Closed by spichugi. Opened by spichugi.
spichugi/389-ds-base pbkdf2_fix  into  master

Download 49771.patch

Bug description: Schema check errors are logged in the error log at start up.
It happens because of the missing attributes that are required by
nsslapdPlugin objectclass. Also we add the Password Storage Schemes
two times: in config.c and in fedse.c.

Fix description: Remove PBKDF2_SHA256 from slapd_bootstrap_config
because setup_internal_backends will happen shortly after (during main.c).

Another part of the fix - add nsslapd-pluginId, nsslapd-pluginVersion,
nsslapd-pluginVendor, and nsslapd-pluginDescription attributes to
fedse.c. The values don't matter because it will be rewritten shortly
after from pwd_storage_scheme_init functions (still during the startup).

https://pagure.io/389-ds-base/issue/49640

Reviewed by: ?

I don't think you need at add these other attributes in the fedse.c It was working before without them.

I think the original issue is fixed by your change to the bootstrap code. Also please make sure upgrade works from 1.3.6 to Master (1/4/0) and that these password storage schemes are added to the config. Thanks!

Thanks Simon for explaining that all the code changes are needed, so LGTM

Ok, upgrade works.

And just for consistency, there is the short explanation :)

After some debugging I've found out that the schema check errors happen here: 
https://pagure.io/389-ds-base/blob/master/f/ldap/servers/slapd/fedse.c#_2491
First I thought it may be worth to disable schema check there, but I didn't find
any flag that I can pass to pblock and it is probably not a very good idea because
we still want schema check working for other entries from
https://pagure.io/389-ds-base/blob/master/f/ldap/servers/slapd/fedse.c#_54
So I added the attributes to the entries and it worked
(and it was overwritten by schema_init functions with right values)

rebased onto 2dad1cd88b29fcc46c92fed9a0427067cccd86fe

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2830

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata