389-ds-base

#49758 Issue 49588 - Add py3 support for tickets : part-3
Closed by spichugi. Opened by aadhikari.
aadhikari/389-ds-base python3-support-ticket-3  into  master

Download 49758.patch

Description: Added py3 support by explicitly changing strings to bytes.

https://pagure.io/389-ds-base/issue/49588

Reviewed by: ??

rebased onto 512e63dada7c8ecd3adf344d5769a7b154a13ab3

rebased onto 8ed138f1114f9f684c330c62ad3feaf251f36b17

rebased onto 99db5dad88f182c5ef12fcd4fa8d4575309d6f94

rebased onto 07112d043e3f13cbab4653f04031acc54758cf4c

rebased onto 31ff8e12abafa7a50c0034ff67b6999580a919ed

rebased onto b281682eafc9697525112f8b776c534d2c77fb19

Let's not keep non-working code commented out, it's better to remove it to avoid confusion.

That's a bit too wordy compared to the the original, maybe just change e.message to e.args[0] and that's it? 

Switched to a new branch 'pr/49758'
[root@server ds]# py.test -v $(git show --pretty="" --name-only HEAD)
============================================================ test session starts ============================================================
platform linux -- Python 3.6.5, pytest-3.6.2, py-1.5.3, pluggy-0.6.0 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /workspace/ds, inifile:
collected 156 items                                                                                                                         
dirsrvtests/tests/tickets/ticket47560_test.py::test_ticket47560 PASSED                                                                [  0%]
dirsrvtests/tests/tickets/ticket47573_test.py::test_ticket47573_init PASSED                                                           [  1%]
dirsrvtests/tests/tickets/ticket47573_test.py::test_ticket47573_one PASSED                                                            [  1%]
dirsrvtests/tests/tickets/ticket47573_test.py::test_ticket47573_two PASSED                                                            [  2%]
dirsrvtests/tests/tickets/ticket47573_test.py::test_ticket47573_three PASSED                                                          [  3%]
dirsrvtests/tests/tickets/ticket47640_test.py::test_ticket47640 PASSED                                                                [  3%]
dirsrvtests/tests/tickets/ticket47653MMR_test.py::test_ticket47653_init PASSED                                                        [  4%]
dirsrvtests/tests/tickets/ticket47653MMR_test.py::test_ticket47653_add PASSED                                                         [  5%]
dirsrvtests/tests/tickets/ticket47653MMR_test.py::test_ticket47653_modify PASSED                                                      [  5%]
dirsrvtests/tests/tickets/ticket47676_test.py::test_ticket47676_init PASSED                                                           [  6%]
dirsrvtests/tests/tickets/ticket47676_test.py::test_ticket47676_skip_oc_at PASSED                                                     [  7%]
dirsrvtests/tests/tickets/ticket47676_test.py::test_ticket47676_reject_action PASSED                                                  [  7%]
dirsrvtests/tests/tickets/ticket47714_test.py::test_ticket47714_init PASSED                                                           [  8%]
dirsrvtests/tests/tickets/ticket47714_test.py::test_ticket47714_run_0 PASSED                                                          [  8%]
dirsrvtests/tests/tickets/ticket47714_test.py::test_ticket47714_run_1 PASSED                                                          [  9%]
dirsrvtests/tests/tickets/ticket47721_test.py::test_ticket47721_init PASSED                                                           [ 10%]
dirsrvtests/tests/tickets/ticket47721_test.py::test_ticket47721_0 PASSED                                                              [ 10%]
dirsrvtests/tests/tickets/ticket47721_test.py::test_ticket47721_1 PASSED                                                              [ 11%]
dirsrvtests/tests/tickets/ticket47721_test.py::test_ticket47721_2 PASSED                                                              [ 12%]
dirsrvtests/tests/tickets/ticket47721_test.py::test_ticket47721_3 PASSED                                                              [ 12%]
dirsrvtests/tests/tickets/ticket47721_test.py::test_ticket47721_4 PASSED                                                              [ 13%]
dirsrvtests/tests/tickets/ticket47781_test.py::test_ticket47781 PASSED                                                                [ 14%]
dirsrvtests/tests/tickets/ticket47787_test.py::test_ticket47787_init PASSED                                                           [ 14%]
dirsrvtests/tests/tickets/ticket47787_test.py::test_ticket47787_2 PASSED                                                              [ 15%]
dirsrvtests/tests/tickets/ticket47808_test.py::test_ticket47808_run PASSED                                                            [ 16%]
dirsrvtests/tests/tickets/ticket47819_test.py::test_ticket47819 PASSED                                                                [ 16%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_init PASSED                                                           [ 17%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_one_container_add PASSED                                              [ 17%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_one_container_mod PASSED                                              [ 18%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_one_container_modrdn PASSED                                           [ 19%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_multi_containers_add PASSED                                           [ 19%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_multi_containers_mod PASSED                                           [ 20%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_multi_containers_modrdn PASSED                                        [ 21%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_across_multi_containers_add PASSED                                    [ 21%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_across_multi_containers_mod PASSED                                    [ 22%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_across_multi_containers_modrdn PASSED                                 [ 23%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_invalid_config_1 PASSED                                               [ 23%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_invalid_config_2 PASSED                                               [ 24%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_invalid_config_3 PASSED                                               [ 25%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_invalid_config_4 PASSED                                               [ 25%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_invalid_config_5 PASSED                                               [ 26%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_invalid_config_6 PASSED                                               [ 26%]
dirsrvtests/tests/tickets/ticket47823_test.py::test_ticket47823_invalid_config_7 PASSED                                               [ 27%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_init PASSED                                                           [ 28%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_0 PASSED                                                          [ 28%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_1 PASSED                                                          [ 29%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_2 PASSED                                                          [ 30%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_3 PASSED                                                          [ 30%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_4 PASSED                                                          [ 31%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_5 PASSED                                                          [ 32%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_6 PASSED                                                          [ 32%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_7 PASSED                                                          [ 33%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_8 PASSED                                                          [ 33%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_9 PASSED                                                          [ 34%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_10 PASSED                                                         [ 35%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_11 PASSED                                                         [ 35%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_12 PASSED                                                         [ 36%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_13 PASSED                                                         [ 37%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_14 PASSED                                                         [ 37%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_15 PASSED                                                         [ 38%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_16 PASSED                                                         [ 39%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_17 PASSED                                                         [ 39%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_18 PASSED                                                         [ 40%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_19 PASSED                                                         [ 41%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_20 PASSED                                                         [ 41%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_21 PASSED                                                         [ 42%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_22 PASSED                                                         [ 42%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_23 PASSED                                                         [ 43%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_24 PASSED                                                         [ 44%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_25 PASSED                                                         [ 44%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_26 PASSED                                                         [ 45%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_27 PASSED                                                         [ 46%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_28 PASSED                                                         [ 46%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_29 PASSED                                                         [ 47%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_30 PASSED                                                         [ 48%]
dirsrvtests/tests/tickets/ticket47828_test.py::test_ticket47828_run_31 PASSED                                                         [ 48%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_init PASSED                                                           [ 49%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_mod_active_user_1 PASSED                                              [ 50%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_mod_active_user_2 PASSED                                              [ 50%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_mod_active_user_3 PASSED                                              [ 51%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_mod_stage_user_1 PASSED                                               [ 51%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_mod_stage_user_2 PASSED                                               [ 52%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_mod_stage_user_3 PASSED                                               [ 53%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_mod_out_user_1 PASSED                                                 [ 53%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_mod_out_user_2 PASSED                                                 [ 54%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_mod_out_user_3 PASSED                                                 [ 55%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_mod_active_user_modrdn_active_user_1 PASSED                           [ 55%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_mod_active_user_modrdn_stage_user_1 PASSED                            [ 56%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_mod_active_user_modrdn_out_user_1 PASSED                              [ 57%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_mod_modrdn_1 PASSED                                                   [ 57%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_mod_stage_user_modrdn_active_user_1 PASSED                            [ 58%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_mod_stage_user_modrdn_stage_user_1 PASSED                             [ 58%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_indirect_active_group_1 PASSED                                        [ 59%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_indirect_active_group_2 PASSED                                        [ 60%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_indirect_active_group_3 PASSED                                        [ 60%]
dirsrvtests/tests/tickets/ticket47829_test.py::test_ticket47829_indirect_active_group_4 PASSED                                        [ 61%]
dirsrvtests/tests/tickets/ticket47833_test.py::test_ticket47829_init PASSED                                                           [ 62%]
dirsrvtests/tests/tickets/ticket47833_test.py::test_ticket47829_mod_stage_user_modrdn_stage_user_1 PASSED                             [ 62%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47838_init FAILED                                                                 [ 63%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47838_run_0 PASSED                                                                [ 64%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47838_run_1 PASSED                                                                [ 64%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47838_run_2 PASSED                                                                [ 65%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47838_run_3 PASSED                                                                [ 66%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47838_run_4 FAILED                                                                [ 66%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47838_run_5 FAILED                                                                [ 67%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47838_run_6 PASSED                                                                [ 67%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47838_run_7 PASSED                                                                [ 68%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47838_run_8 FAILED                                                                [ 69%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47838_run_9 FAILED                                                                [ 69%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47838_run_10 PASSED                                                               [ 70%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47838_run_11 PASSED                                                               [ 71%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47928_run_0 PASSED                                                                [ 71%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47928_run_1 PASSED                                                                [ 72%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47928_run_2 PASSED                                                                [ 73%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47928_run_3 PASSED                                                                [ 73%]
dirsrvtests/tests/tickets/ticket47838_test.py::test_47838_run_last PASSED                                                             [ 74%]
dirsrvtests/tests/tickets/ticket47869MMR_test.py::test_ticket47869_init PASSED                                                        [ 75%]
dirsrvtests/tests/tickets/ticket47869MMR_test.py::test_ticket47869_check PASSED                                                       [ 75%]
dirsrvtests/tests/tickets/ticket47871_test.py::test_ticket47871_init PASSED                                                           [ 76%]
dirsrvtests/tests/tickets/ticket47871_test.py::test_ticket47871_1 PASSED                                                              [ 76%]
dirsrvtests/tests/tickets/ticket47871_test.py::test_ticket47871_2 PASSED                                                              [ 77%]
dirsrvtests/tests/tickets/ticket47900_test.py::test_ticket47900 PASSED                                                                [ 78%]
dirsrvtests/tests/tickets/ticket47910_test.py::test_ticket47910_logconv_start_end_positive PASSED                                     [ 78%]
dirsrvtests/tests/tickets/ticket47910_test.py::test_ticket47910_logconv_start_end_negative PASSED                                     [ 79%]
dirsrvtests/tests/tickets/ticket47910_test.py::test_ticket47910_logconv_start_end_invalid PASSED                                      [ 80%]
dirsrvtests/tests/tickets/ticket47910_test.py::test_ticket47910_logconv_noaccesslogs PASSED                                           [ 80%]
dirsrvtests/tests/tickets/ticket47920_test.py::test_ticket47920_init PASSED                                                           [ 81%]
dirsrvtests/tests/tickets/ticket47920_test.py::test_ticket47920_mod_readentry_ctrl PASSED                                             [ 82%]
dirsrvtests/tests/tickets/ticket47921_test.py::test_ticket47921 PASSED                                                                [ 82%]
dirsrvtests/tests/tickets/ticket47988_test.py::test_ticket47988_init FAILED                                                           [ 83%]
dirsrvtests/tests/tickets/ticket47988_test.py::test_ticket47988_1 FAILED                                                              [ 83%]
dirsrvtests/tests/tickets/ticket47988_test.py::test_ticket47988_2 FAILED                                                              [ 84%]
dirsrvtests/tests/tickets/ticket47988_test.py::test_ticket47988_3 FAILED                                                              [ 85%]
dirsrvtests/tests/tickets/ticket47988_test.py::test_ticket47988_4 FAILED                                                              [ 85%]
dirsrvtests/tests/tickets/ticket47988_test.py::test_ticket47988_5 FAILED                                                              [ 86%]
dirsrvtests/tests/tickets/ticket47988_test.py::test_ticket47988_6 FAILED                                                              [ 87%]
dirsrvtests/tests/tickets/ticket48013_test.py::test_ticket48013 PASSED                                                                [ 87%]
dirsrvtests/tests/tickets/ticket48026_test.py::test_ticket48026 PASSED                                                                [ 88%]
dirsrvtests/tests/tickets/ticket48109_test.py::test_ticket48109 PASSED                                                                [ 89%]
dirsrvtests/tests/tickets/ticket48170_test.py::test_ticket48170 PASSED                                                                [ 89%]
dirsrvtests/tests/tickets/ticket48194_test.py::test_init FAILED                                                                       [ 90%]
dirsrvtests/tests/tickets/ticket48194_test.py::test_run_0 FAILED                                                                      [ 91%]
dirsrvtests/tests/tickets/ticket48194_test.py::test_run_1 PASSED                                                                      [ 91%]
dirsrvtests/tests/tickets/ticket48194_test.py::test_run_2 PASSED                                                                      [ 92%]
dirsrvtests/tests/tickets/ticket48194_test.py::test_run_3 PASSED                                                                      [ 92%]
dirsrvtests/tests/tickets/ticket48194_test.py::test_run_4 PASSED                                                                      [ 93%]
dirsrvtests/tests/tickets/ticket48194_test.py::test_run_5 PASSED                                                                      [ 94%]
dirsrvtests/tests/tickets/ticket48194_test.py::test_run_6 PASSED                                                                      [ 94%]
dirsrvtests/tests/tickets/ticket48194_test.py::test_run_8 PASSED                                                                      [ 95%]
dirsrvtests/tests/tickets/ticket48194_test.py::test_run_9 FAILED                                                                      [ 96%]
dirsrvtests/tests/tickets/ticket48194_test.py::test_run_11 PASSED                                                                     [ 96%]
dirsrvtests/tests/tickets/ticket48212_test.py::test_ticket48212 PASSED                                                                [ 97%]
dirsrvtests/tests/tickets/ticket48214_test.py::test_ticket48214_run PASSED                                                            [ 98%]
dirsrvtests/tests/tickets/ticket48233_test.py::test_ticket48233 PASSED                                                                [ 98%]
dirsrvtests/tests/tickets/ticket48370_test.py::test_ticket48370 PASSED                                                                [ 99%]
dirsrvtests/tests/tickets/ticket48383_test.py::test_ticket48383 PASSED                                                                [100%]
================================================= 15 failed, 141 passed in 1086.07 seconds ==================================================

Good work! I propose that we merge changes for the passing test cases and keep working on the rest in a next batch.

rebased onto 1d37b101c95a3acf8c3e0399a1121312b166515b

rebased onto 97c32eae5505fc165b43a11ed186cdc26e2e4e29

rebased onto c0a80d282aed7d170d7449956bde6f4e06715daa

Pull-Request has been merged by vashirov

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2817

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.