389-ds-base

#49727 Ticket 49726 - DS only accepts RSA and Fortezza cipher families
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base ticket49726  into  master

Download 49727.patch

Bug Description: Currently DS only accepts fortezza and RSA cipher families.
This prevents things like ECC certificates from being used.

Fix Description: Instead of hardcoding the cipher families, just grab the
current type and use it.

              Also cleaned up code: removed unncessary "ifdefs", and switched
              for loops to use size_t.

https://pagure.io/389-ds-base/issue/49726

Reviewed by: ?

You got my ACK for the fix itself.

I noticed the PR drops checks for USE_OPENLDAP. For that, we should also remove the #include "ldap_ssl.h" at the top of the file. ldap_ssl.h does not even seem to be in the tree. Other than that, it looks all right to me.

Additionally, I guess it makes sense to get rid of --with-openldap build flag altogether. @mreynolds, should we file a ticket?

Yeah we need a different ticket to "remove openldap ifdefs" completely and make openldap the default. I just like to cleanup code when I touch files. Anyway changes applied

rebased onto 27a16a068887e5b9fcab3b4507d58a18e6f1d1ec

Pull-Request has been merged by mreynolds

Created issue #49730 for "remove openldap ifdefs".

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2786

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.