#49659 Issue 49657 - Fix cascading replication scenario in lib389 API
Closed by spichugi. Opened by spichugi.
spichugi/389-ds-base casc_topo_fix  into  master

Download 49659.patch

Bug description: We should be able to create cascading replication topology
with existing lib389 API. Fix existing topology in topologies.py
and add the functionality to replica.py API accordingly.

Fix description: Add the code to join_hub function.
Get agreement name from the last three port numbers.
When we call _create_service_group on read-only instance
do not try to create it.
Generate the replica credentials when adding the service account
and store them in ReplicationManager object.
Fix a few small issues in replica.py.
In topologies.py, divide the instance and replica creation.
Refactor topology_m1h1c1 according to the changes.
During the finalizer, check if instance exists before the removal.

https://pagure.io/389-ds-base/issue/49657

Reviewed by: ?

rebased onto bd7081379adb82dd3e5b0a8e7dd4f740d3e011e1

rebased onto c898599b2a890f576c529635ad467d16270ac764

same typo

I prefer "from_r" instead of "fr_r". It's a little more "wordy", but it's much easier to understand. Any objection to changing this throughout this PR?

Looks good, just a couple of minor issues...

rebased onto 31b8d97d839c82901e00c9e8e792652c7f893e1e

rebased onto 0e5358a756c75ae6fdc61651cc60980ec74ce007

A gentle reminder for the PR review... We really depend on this PR a lot in our upstream testing.

A gentle reminder for the PR review... We really depend on this PR a lot in our upstream testing.

Sorry, yeah LGTM!

rebased onto 50732c9e8767b60c4bd52b0c48924b5093897dd5

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2718

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata