#49651 Issue 49538 - replace cacertdir_rehash with openssl rehash
Closed by spichugi. Opened by spichugi.
spichugi/389-ds-base rehash_fix  into  master

Download 49651.patch

Bug description: Enable TLS method fails on newer Fedora systems.
It complains that cacertdir_rehash tool is not found.

Fix description: The reason is that authconfig was replaced with
authselect package. Authconfig shipped a tool called cacertdir_rehash.
We need to switch to native openssl command: openssl rehash
that serves the same purpose.
We also have it on RHEL7 so we don't need to perform any additional actions.
Also we can remove authconfig from 389-ds-base.spec.in because 'cacertdir_rehash'
was the only reason why we had the dependency.

https://pagure.io/389-ds-base/issue/49538

Reviewed by: ?

JFTR: nack. As discussed over IRC, the openssl rehash is not there on rhel-7 as it ships openssl-1.0 which does not contain it. openssl rehash is present since openssl-1.1.

rebased onto 8e7056befdc3acbd675f42d8f388a1d701994dc2

As per IRC discussion, changing to /usr/bin/c_rehash tool which works the same way as openssl rehash.
Also, c_rehash is available on both RHEL7 and Fedora so we can use it for the compatibility.

Testing...

rebased onto ce7099e8a7245c252de73799ac880c9a83feb811

I've tested the change and it works on both Fedora and RHEL7.

Also, I fixes a small thing in remove_ds_instance function.
We should ignore FileNotFound errors while removing the instance.
It is the small thing I missed in https://pagure.io/389-ds-base/pull-request/49641

Also, I fixes a small thing in remove_ds_instance function.
We should ignore FileNotFound errors while removing the instance.
It is the small thing I missed in https://pagure.io/389-ds-base/pull-request/49641

Could you please make a note of this change in the commit message? I'd found it useful in the future. ;)

Could you please make a note of this change in the commit message? I'd found it useful in the future. ;)

For sure. It is there - https://pagure.io/fork/spichugi/389-ds-base/c/ce7099e8a7245c252de73799ac880c9a83feb811

Unfortunatly, pagure doesn't change the PR description when you change the commit message.

Oh man... it's an ack then. :)

rebased onto a86ff68e4fe8241a5683f441da5a0eb513e454c1

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2710

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata